Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for QuickLook target folders #71

Merged
merged 2 commits into from Nov 23, 2018

Conversation

nunopedrosa
Copy link
Contributor

Just a simple addition to the option. For my needs (QLSVGSprite), I'd rather install for each user, giving instructions to create the ~/Library/QuickLook folder if needed.

But, from what I gather from other discussions, maybe the common QuickLook install location, /Library/QuickLook, is the better option for common usage.

Just a simple addition to the option.
@aonez
Copy link
Member

aonez commented Nov 23, 2018

maybe the common QuickLook install location, /Library/QuickLook, is the better option for common usage

I'm with that, just because ~/Library/QuickLook does not exist by default on any Mac OS X or macOS installation. For most users the global folder will be better, if we are looking for installation easiness.

screen shot 2018-11-23 at 11 47 56

README.md Outdated Show resolved Hide resolved
create-dmg Outdated Show resolved Hide resolved
To make installation easier, default install location to system wide /Library/QuickLook, instead of HOME/Library/Location.
@aonez
Copy link
Member

aonez commented Nov 23, 2018

Thanks @nunopedrosa!

@aonez aonez merged commit 95ea395 into create-dmg:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants