Skip to content

changes should allow arbitrary query params #1

Open
jchris opened this Issue Aug 27, 2010 · 1 comment

2 participants

@jchris
jchris commented Aug 27, 2010

I need to specify a filter for my changes function. I think the first argument should be an options hash so that that can be done. (Also filters can take arbitrary query params, so those are definitely needed.)

I do agree with the default hearbeat and feed setting you have.

@creationix
Owner

I'd like to keep the API as minimal as possible. If you want to do anything custom, the request method makes that pretty easy. I really don't want to force people to use my abstraction methods for every possible use case. I find abstractions leaky as best most the time.

That said, you're welcome to submit a patch for this. I'm not set on the API for changes yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.