Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Test & error handling #5

Open
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

flashingpumpkin commented Dec 8, 2010

The view function didn't handle errors properly. Now it actually looks at the content returned before calling the callback.
Also, I adopted a queue for views. :-o

michael commented Dec 17, 2010

Had the same problem.

Flashingpumpkin: Not sure if Tim would rather prefer delivering the original error object
{ error: 'not_found', reason: 'missing_named_view' }

instead of a modified one, in order to keep the code-base super-small.

Thx for the patch anyway :)

-- Michael

Collaborator

candland commented Feb 24, 2011

@devioustree Should this pull request be closed? Looks like it on a quick glance.

michael commented Feb 27, 2011

Fixed this in my fork, among other things. See michael/couch-client@011698b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment