Article on Session-based Authorization with Socket.IO #77

Merged
merged 7 commits into from Dec 28, 2012

Conversation

Projects
None yet
4 participants
@shaharke
Contributor

shaharke commented Dec 20, 2012

Hi,

I've written a short how-to on configuring socket.io to perform session-based authorization based on Express' session.

Hope you find it interesting.

Shahar

@creationix

This comment has been minimized.

Show comment Hide comment
@creationix

creationix Dec 27, 2012

Owner

@kriskowal, @pgte, @JoshuaGross, @nrstott, @gopherkhan, would one of you have time to review this article?

Owner

creationix commented Dec 27, 2012

@kriskowal, @pgte, @JoshuaGross, @nrstott, @gopherkhan, would one of you have time to review this article?

@nrstott

This comment has been minimized.

Show comment Hide comment
@nrstott

nrstott Dec 27, 2012

Collaborator

Will be happy to review it this evening if no one gets to it before me.
Putting it on my calendar.

On Wed, Dec 26, 2012 at 9:50 PM, Tim Caswell notifications@github.comwrote:

@kriskowal https://github.com/kriskowal, @pgte https://github.com/pgte,
@JoshuaGross https://github.com/JoshuaGross, @nrstotthttps://github.com/nrstott,
@gopherkhan https://github.com/gopherkhan, would one of you have time
to review this article?


Reply to this email directly or view it on GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11700433.

Collaborator

nrstott commented Dec 27, 2012

Will be happy to review it this evening if no one gets to it before me.
Putting it on my calendar.

On Wed, Dec 26, 2012 at 9:50 PM, Tim Caswell notifications@github.comwrote:

@kriskowal https://github.com/kriskowal, @pgte https://github.com/pgte,
@JoshuaGross https://github.com/JoshuaGross, @nrstotthttps://github.com/nrstott,
@gopherkhan https://github.com/gopherkhan, would one of you have time
to review this article?


Reply to this email directly or view it on GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11700433.

@gopherkhan

This comment has been minimized.

Show comment Hide comment
@gopherkhan

gopherkhan Dec 27, 2012

Collaborator

Same here. Earliest I could get to it is this evening.

--Chris

On 12/27/2012 07:41 AM, Nathan wrote:

Will be happy to review it this evening if no one gets to it before me.
Putting it on my calendar.

On Wed, Dec 26, 2012 at 9:50 PM, Tim Caswell
notifications@github.comwrote:

@kriskowal https://github.com/kriskowal, @pgte
https://github.com/pgte,
@JoshuaGross https://github.com/JoshuaGross,
@nrstotthttps://github.com/nrstott,
@gopherkhan https://github.com/gopherkhan, would one of you have time
to review this article?


Reply to this email directly or view it on
GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11700433.


Reply to this email directly or view it on GitHub
#77 (comment).

Collaborator

gopherkhan commented Dec 27, 2012

Same here. Earliest I could get to it is this evening.

--Chris

On 12/27/2012 07:41 AM, Nathan wrote:

Will be happy to review it this evening if no one gets to it before me.
Putting it on my calendar.

On Wed, Dec 26, 2012 at 9:50 PM, Tim Caswell
notifications@github.comwrote:

@kriskowal https://github.com/kriskowal, @pgte
https://github.com/pgte,
@JoshuaGross https://github.com/JoshuaGross,
@nrstotthttps://github.com/nrstott,
@gopherkhan https://github.com/gopherkhan, would one of you have time
to review this article?


Reply to this email directly or view it on
GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11700433.


Reply to this email directly or view it on GitHub
#77 (comment).

@nrstott

This comment has been minimized.

Show comment Hide comment
@nrstott

nrstott Dec 28, 2012

Collaborator

I'm reviewing it now.

Collaborator

nrstott commented Dec 28, 2012

I'm reviewing it now.

@ghost ghost assigned nrstott Dec 28, 2012

@nrstott

This comment has been minimized.

Show comment Hide comment
@nrstott

nrstott Dec 28, 2012

Collaborator

It's a good article. One thing, please format the markdown so that a 'description' will appear on the front page. Currently there is none and that makes the front page of the site look a bit off. When you've done that I'll be happy to review again and merge.

edit: after reviewing your 70-line elaborately commented snippet, I withdraw my previous statement requesting more explanation

Collaborator

nrstott commented Dec 28, 2012

It's a good article. One thing, please format the markdown so that a 'description' will appear on the front page. Currently there is none and that makes the front page of the site look a bit off. When you've done that I'll be happy to review again and merge.

edit: after reviewing your 70-line elaborately commented snippet, I withdraw my previous statement requesting more explanation

@shaharke

This comment has been minimized.

Show comment Hide comment
@shaharke

shaharke Dec 28, 2012

Contributor

Ah.. saw your last comment only after the push. Anyway, I feel it will look better with a description and I tried to keep it short and to the point.
I also fixed some typos.

Contributor

shaharke commented Dec 28, 2012

Ah.. saw your last comment only after the push. Anyway, I feel it will look better with a description and I tried to keep it short and to the point.
I also fixed some typos.

nrstott added a commit that referenced this pull request Dec 28, 2012

Merge pull request #77 from shaharke/master
Article on Session-based Authorization with Socket.IO

@nrstott nrstott merged commit 66fba7f into creationix:master Dec 28, 2012

@shaharke

This comment has been minimized.

Show comment Hide comment
@shaharke

shaharke Dec 28, 2012

Contributor

Thanks guys! Hope to add more content in the future.

Contributor

shaharke commented Dec 28, 2012

Thanks guys! Hope to add more content in the future.

@creationix

This comment has been minimized.

Show comment Hide comment
@creationix

creationix Dec 28, 2012

Owner

Yay, the auto-publish hook is still working!

Owner

creationix commented Dec 28, 2012

Yay, the auto-publish hook is still working!

@nrstott

This comment has been minimized.

Show comment Hide comment
@nrstott

nrstott Dec 28, 2012

Collaborator

Thanks for your contribution.

On Fri, Dec 28, 2012 at 9:04 AM, Tim Caswell notifications@github.comwrote:

Yay, the auto-publish hook is still working!


Reply to this email directly or view it on GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11733410.

Collaborator

nrstott commented Dec 28, 2012

Thanks for your contribution.

On Fri, Dec 28, 2012 at 9:04 AM, Tim Caswell notifications@github.comwrote:

Yay, the auto-publish hook is still working!


Reply to this email directly or view it on GitHubhttps://github.com/creationix/howtonode.org/pull/77#issuecomment-11733410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment