Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

utf8 support #11

Merged
merged 11 commits into from Dec 19, 2012

Conversation

Projects
None yet
2 participants
Collaborator

substack commented Dec 19, 2012

This pull request firstly refactors the test.js into a proper test suite that you can run with npm test and it will output TAP and give you an exit code of 0 on success. I then added a failing utf8 test so I could make it pass. The test suite will be useful for getting this module running with browser tests on testling-ci, which I will hack together shortly.

If you don't want any of the test commits you can just cherry-pick fba4e12 which has the actual fix but the tests are nice.

Fixes issue #7.

@creationix creationix added a commit that referenced this pull request Dec 19, 2012

@creationix creationix Merge pull request #11 from substack/utf8
utf8 support
d7160d9

@creationix creationix merged commit d7160d9 into creationix:master Dec 19, 2012

Owner

creationix commented Dec 19, 2012

Thanks James!

Owner

creationix commented Dec 19, 2012

Published to npm as jsonparse@0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment