buggy call of git log #7

Open
payload opened this Issue Jul 7, 2011 · 2 comments

2 participants

@payload

You call git log without deactivating colors.

https://github.com/creationix/node-git/blob/master/lib/git-fs.js#L197

A user who has configures git to always print color will see a weird error message cause the regex-parser won't match. You can fix this by adding the option -c color.ui=never before the log in git log.

Generally you should add this option to all of your git commands and specially you could look into my own thin wrapper around git commands ;-) https://github.com/payload/node-treeeater/

I discovered this error while using https://github.com/mklabs/nabe

@creationix
Owner

Is this still an issue? I've been swamped and had this issue starred to look at later.

@payload

since there is no -c color.ui=never in gitExec
nor in args
i bet it is still an issue.
though i didn't test it.

@payload payload closed this Sep 22, 2011
@payload payload reopened this Sep 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment