Fix remove. #30

Merged
merged 1 commit into from Apr 2, 2013

Projects

None yet

6 participants

@stuarts
stuarts commented Oct 8, 2011

The document was being deleted off of the index on the checkQueue update.

But the iterator wasn't being nulled so if(value !== undefined) wasn't preventing the document's index from being re-set on self.index and subsequent query.all's were failing.

I just added a value = undefined to the delete logic.

Stuart Strader Fix remove. Document re-added to index so subsequent queries would fa…
…il. Set the documents index to undefined so later logic will not add it back
5c75678
@dr-BEat
dr-BEat commented Nov 5, 2011

Nice! This one saved my day.
Thanks!

@flosse
flosse commented Jan 16, 2012

+1

@rc1
rc1 commented Jan 30, 2012

ditto +1 thanks!

@gulian
gulian commented Apr 2, 2013

Thanks @stuarts !

@creationix it should be nice to update your npm repository with this pull request 😉

@creationix creationix merged commit cf68521 into creationix:master Apr 2, 2013
@creationix
Owner

Published as nstore@0.5.2! Thanks for the fix. I had high hopes for nStore and then never had time to fix all the data corruption bugs. Maybe it will become useful yet.

@stuarts
stuarts commented Apr 2, 2013

Your welcome! Thanks for the great project, I bet it has saved a bunch of
time for people over the years who would otherwise have rolled their own
solution. It is in that sweet spot of simplicity and feature set.

On Tue, Apr 2, 2013 at 6:28 AM, Tim Caswell notifications@github.comwrote:

Published as nstore@0.5.2! Thanks for the fix. I had high hopes for
nStore and then never had time to fix all the data corruption bugs. Maybe
it will become useful yet.


Reply to this email directly or view it on GitHubhttps://github.com/creationix/nstore/pull/30#issuecomment-15774767
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment