July 5th "Shellcheck recommendations" patch broke profile set up

[jcsalem]

In install.sh, changing the printf lines from:
printf $SOURCE_STR
to
printf "%s" "$SOURCE_STR"
broke the profile appending code. With printf "%s", the "\n" characters in $SOURCE_STR are written verbatim rather than a written as new lines. E.G., it looks like this in my .bash_profile:
\nexport NVM_DIR="/home/vagrant/.nvm"\n[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm

You should revert that change.

Commit ID: e0537ce

PS: You should add a trailing newline to the insertion as well.

[ljharb]

Thanks for reporting - (related to #457, ping @koenpunt)

[koenpunt]

Not really related, why did you change it to the string substitution version?

[ljharb]

I've been trying to follow shellcheck's recommendations, but obviously I didn't understand the implications of this particular change.

[ljharb]

That said, this is in master, not a tagged release, so it shouldn't break anyone - nobody should be installing off of master except to test upcoming releases.

[koenpunt]

The additional quotes are proper changes, but in the case of printf, it has a format and values, and in this case the string is the format. No biggie

[jcsalem]

This doesn't fix the issue.
You need to remove the format string in line 125 as well. It should read:
printf "$SOURCE_STR\n" >> "$PROFILE"

[ljharb]

Fixed in #460

[jcsalem]

:-)