Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Zsh compatibility #157

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

koenpunt commented Oct 21, 2012

Fixed compatibility with zsh
Added method to normalize versions so they are comparable and method to 'format' a version number (prepend v if not starting with number).

[[ -r $NVM_DIR/bash_completion ]] && . $NVM_DIR/bash_completion 

still does not work with zsh.

bashcompinit 

should do the trick.

taken from git_complete.bash:

if [[ -n ${ZSH_VERSION-} ]]; then
    autoload -U +X bashcompinit && bashcompinit
fi

vvo commented Nov 16, 2012

I do not understand I use zsh and nvm already, what are you fixing?

Do you also use completion like in https://github.com/creationix/nvm#bash-completion?
For me that only works with bashcompinit.

Collaborator

ljharb commented Mar 15, 2014

I'm going to close this - @koenpunt, if you're interested in reopening this, please freshly rebase on master, and ensure it works in zsh, bash, and sh. It would also be helpful if you described in more detail the purpose of this PR.

@ljharb ljharb closed this Mar 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment