Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code in nvm_npm_global_modules() #1742

Conversation

PeterDaveHello
Copy link
Collaborator

No matter what's the result of the condition here, the path is always the same.

No matter what's the result of the condition here, the path is the same.
@PeterDaveHello PeterDaveHello force-pushed the remove-duplicate-code-in-nvm_npm_global_modules branch from 64e11a4 to bb80349 Compare February 22, 2018 01:43
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's been this way since 0b41352. Good catch!

@ljharb ljharb merged commit bb80349 into nvm-sh:master Feb 22, 2018
@PeterDaveHello PeterDaveHello deleted the remove-duplicate-code-in-nvm_npm_global_modules branch February 22, 2018 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants