Fixes Issue 199 #200

Merged
merged 1 commit into from Mar 7, 2013

Conversation

Projects
None yet
2 participants
Collaborator

croach commented Mar 1, 2013

Fixes issue 199 where the bash completion was not working in ZSH
because the builtin bash command complete was not found. The fix
executes the bashcompinit command which creates the complete
function for the Z shell.

Fixes issue 199
Fixes issue 199 where the bash completion was not working in ZSH
because the builtin bash command `complete` was not found. The fix
executes the `bashcompinit` command which creates the `complete`
function for the Z shell.
Owner

creationix commented Mar 4, 2013

The reason I've been hesitent to pull zsh patches is historically they break people's bash environment pretty often. I don't have time to test every patch in all the shells. If I pull this, you are responsible for any bash environments that break because of this patch. Are you OK with that?

Collaborator

croach commented Mar 7, 2013

Hi Tim,

Yeah, I'm fine with that. I actually work in both environments, Bash and Zsh, all the time, so I've made sure it works in both. Also, the change is surrounded by check to make sure that you are in the Z shell before running anything, so it shouldn't affect the Bash environment at all. Finally, the change itself came from studying the code for Git's bash completion, so it's heavily tested on a daily basis by anyone running Git. It shouldn't be a problem, and I'm more than happy to deal with any issues that may arise from its inclusion.

Cheers,

Christopher

creationix added a commit that referenced this pull request Mar 7, 2013

@creationix creationix merged commit 01189e1 into creationix:master Mar 7, 2013

Owner

creationix commented Mar 7, 2013

Also @croach since you do use nvm in bash and zsh, you can become a maintainer with pull request rights if you want?

Collaborator

croach commented Mar 12, 2013

That'd be great, though I've never been a maintainer on anything other than
my own projects. Is there anything I need to know? or does this mainly just
give me access to commit my own changes? Would I also be combing through
the current pull requests and helping out with those as well? Just let me
know. I'd be happy to help out.

Cheers,

Christopher

On Thu, Mar 7, 2013 at 3:03 PM, Tim Caswell notifications@github.comwrote:

Also @croach https://github.com/croach since you do use nvm in bash and
zsh, you can become a maintainer with pull request rights if you want?


Reply to this email directly or view it on GitHubhttps://github.com/creationix/nvm/pull/200#issuecomment-14592265
.

Christopher Roach
http://christopherroach.com

Owner

creationix commented Mar 12, 2013

It would mean having full commit rights. In return, I would expect you to comb through pull requests and help when you have time. Also I'd really like if nvm stayed simple and didn't feature bloat, but since I don't have time to do anything with it anymore, I feel I don't have much say in that.

Collaborator

croach commented Mar 12, 2013

I don't think that'd be a problem at all, and I agree with what you're
saying about keeping it simple. I feel as if the software is feature
complete right now, so really I would mainly be interested in changes that
just make it more solid and robust.

On Tue, Mar 12, 2013 at 12:20 PM, Tim Caswell notifications@github.comwrote:

It would mean having full commit rights. In return, I would expect you to
comb through pull requests and help when you have time. Also I'd really
like if nvm stayed simple and didn't feature bloat, but since I don't have
time to do anything with it anymore, I feel I don't have much say in that.


Reply to this email directly or view it on GitHubhttps://github.com/creationix/nvm/pull/200#issuecomment-14797032
.

Christopher Roach
http://christopherroach.com

Owner

creationix commented Mar 12, 2013

If anything, I'm sure the code can be simplified by someone who can understand it all and has a good grasp of the two shells. I never was good at bash and needed a lot of help when I started this project. You now have commit access, make me proud.

Collaborator

croach commented Mar 12, 2013

Cool! Thanks, and I'll do my best :-)

Christopher

On Tue, Mar 12, 2013 at 12:44 PM, Tim Caswell notifications@github.comwrote:

If anything, I'm sure the code can be simplified by someone who can
understand it all and has a good grasp of the two shells. I never was good
at bash and needed a lot of help when I started this project. You now have
commit access, make me proud.


Reply to this email directly or view it on GitHubhttps://github.com/creationix/nvm/pull/200#issuecomment-14798462
.

Christopher Roach
http://christopherroach.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment