Added command to get current nvm environment. #205

Merged
merged 4 commits into from Dec 17, 2013

Conversation

Projects
None yet
2 participants
Contributor

deiga commented Mar 13, 2013

As an rvm user I constantly try nvm current and realising I need nvm list, this reduces typing

Contributor

deiga commented Oct 9, 2013

Can we get a merge? :)

Collaborator

ljharb commented Oct 9, 2013

A test would be nice :-) but otherwise lgtm

Contributor

deiga commented Oct 10, 2013

There's a simple test now :) Wasn't really sure on how to test this :)

Contributor

deiga commented Dec 16, 2013

Can we get a merge!? :)

@ljharb ljharb commented on an outdated diff Dec 16, 2013

..."nvm current" should display current nvm environment.
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+. ../../nvm.sh
+nvm current | grep current
@ljharb

ljharb Dec 16, 2013

Collaborator

all of the other tests explicitly return a true or false (using bash bracket notation) - this one just returns content. Can you make this assertion more explicit?

Contributor

deiga commented Dec 17, 2013

@ljharb Fixed the test, although I'm not even sure it tests correctly...

Collaborator

ljharb commented Dec 17, 2013

This works for me - however node -v tells you the current version just fine.

@ljharb ljharb added a commit that referenced this pull request Dec 17, 2013

@ljharb ljharb Merge pull request #205 from deiga/add-current-command
Added command to get current nvm environment.
d7015c7

@ljharb ljharb merged commit d7015c7 into creationix:master Dec 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment