Hotfix: correctly map curl's `-C -` to wget #474

Merged
merged 1 commit into from Jul 16, 2014

Conversation

Projects
None yet
3 participants
@mgol
Contributor

mgol commented Jul 16, 2014

wget doesn't need or accept the - parameter to -c

Without it, on a curl-less OS nvm install doesn't work since wget tries to download from http://-/ apart from the real Node file which causes the process to fail and makes nvm think the binary download didn't succeed.

So this is pretty critical to wget users.

Should wget nvm install be tested somehow? If it was, this issue wouldn't happen.

@mgol mgol changed the title from Correctly map curl's `-C -` to wget to Hotfix: correctly map curl's `-C -` to wget Jul 16, 2014

Hotfix: correctly map curl's `-C -` to wget
wget doesn't need or accept the `-` parameter to `-c`. This incorrect
mapping causes `nvm install` to fail on a curlless OS.
@koenpunt

This comment has been minimized.

Show comment
Hide comment
@koenpunt

koenpunt Jul 16, 2014

Contributor

👍

Contributor

koenpunt commented Jul 16, 2014

👍

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Jul 16, 2014

Collaborator

Thanks! I'm not sure how to test any part of the install script, since Travis always has nvm (and curl anyways) pre-installed.

Collaborator

ljharb commented Jul 16, 2014

Thanks! I'm not sure how to test any part of the install script, since Travis always has nvm (and curl anyways) pre-installed.

ljharb added a commit that referenced this pull request Jul 16, 2014

Merge pull request #474 from mzgol/wget-hotfix
Hotfix: correctly map curl's `-C -` to wget

@ljharb ljharb merged commit 3b42df8 into creationix:master Jul 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mgol mgol deleted the mgol:wget-hotfix branch Jul 16, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 18, 2014

Contributor

@ljharb You could unload & uninstall nvm at the beginning of the test, couldn't you? With curl it's a little harder but perhaps it's possible to remove curl in a Travis test?

Contributor

mgol commented Jul 18, 2014

@ljharb You could unload & uninstall nvm at the beginning of the test, couldn't you? With curl it's a little harder but perhaps it's possible to remove curl in a Travis test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment