Skip to content

read file in UTF8 #28

Closed
jamuhl opened this Issue Aug 15, 2011 · 2 comments

2 participants

@jamuhl
jamuhl commented Aug 15, 2011

I can't write an article.markdown in utf8 (eg. german ä,ö,ü) because Git.readFile (git-fs.js: line 237) reads with 'binary' encoding.

Solution might be to pass in an optional parameter 'encoding'?

@creationix
Owner

If possible, could we make it just use Buffers now. I'd rather not use the "binary" encoding for anything. I think I did it before because that was all node supported for child processes at the time.

@jamuhl jamuhl closed this Aug 16, 2011
@jamuhl
jamuhl commented Aug 16, 2011

Just tested removing the optional encoding in fs.readFile like you suggested. Had to convert the returned buffer to string in some places, but works. If i get the time i will fork the project and do a pull request. thanks for you help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.