Call 'next()' on ENOENT errors #12

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@TooTallNate

Hey Tim, I'm just trying to clean up the extraneous error message that get printed to my server's stderr.

When a Googlebot tries for a "robot.txt", Wheat will call next(err) instead of just next(), resulting in this:
Error: git --git-dir=/home/nrajlich/node-http-server/tootallnate.net/blog.git show dbc2ec41609583ce92243936415a772966570ed1:articles/robots.txt
fatal: ambiguous argument 'dbc2ec41609583ce92243936415a772966570ed1:articles/robots.txt': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions

    at ChildProcess.<anonymous> (/usr/local/lib/node/.npm/git-fs/0.0.4/package/lib/git-fs.js:176:16)
    at ChildProcess.emit (events:33:26)
    at Stream.<anonymous> (child_process:131:12)
    at Stream.emit (events:26:26)
    at Array.0 (net:987:12)
    at EventEmitter._tickCallback (node.js:53:20)
    at node.js:764:9

This fixes that, and also goes hand-in-hand with the pull request for git-fs I'm about to send to you.

@TooTallNate TooTallNate Pass through to the next 'connect' layer on an ENOENT error (i.e. req…
…uested file does not exist).

This matches the behavior of the 'staticProvider' middleware in 'connect', and will also prevent unnecessary errors being spewed to the server's stderr, when it should really only respond with a 404.
f16848f
@creationix
Owner

Got it! thanks.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment