Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove proto module as it seems to be unused and causes conflicts in other modules. #48

Open
wants to merge 1 commit into from

1 participant

@posco2k8

The proto module pollutes Object.prototype and causes issues with other modules. For example, I am using connect-assets and wheat together. connect-assets couldn't parse sprocket requires in a JavaScript file because the module dep-graph relies on a property called map on one of its objects, which conflicts with proto.

It looks like the methods exposed in the proto module aren't even being used in wheat and I've been running a custom fork of the project without it for a few days with no issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 9, 2013
  1. Remove proto module as it seems to be unused and causes conflicts in …

    posco2k8 authored
    …other modules.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 4 deletions.
  1. +0 −2  lib/wheat.js
  2. +1 −2  package.json
View
2  lib/wheat.js
@@ -20,8 +20,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/
-
-require('proto');
var Url = require('url'),
Git = require('git-fs'),
Renderers = require('./wheat/renderers');
View
3  package.json
@@ -16,7 +16,6 @@
"simple-mime": ">=0.0.1",
"haml": ">=0.2.5",
"step": ">=0.0.3",
- "datetime": "0.0.3",
- "proto": ">=0.1.0"
+ "datetime": "0.0.3"
}
}
Something went wrong with that request. Please try again.