New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual bug on deed page #692

Open
mzeinstra opened this Issue Oct 24, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@mzeinstra

mzeinstra commented Oct 24, 2017

See attached image.

My browser is Chrome 62.0.3202.62 on mac 10.13.0 with adblocker and ghostery (tracking blocking).

cc visual bug

@mzeinstra

This comment has been minimized.

Show comment
Hide comment
@mzeinstra

mzeinstra Aug 16, 2018

Can we fix this? It has been almost 6 months since I reported that second logo left to non-commercial has a duplicate image.

It seems to occur when the NC wants to display the currency of the area (e.g. Euro or the Japanese Yen) in the old design but the dollar in the new design.

It is due to this file: https://github.com/creativecommons/creativecommons.org/blob/master/docroot/includes/jurisdictions.css
and occurs on the licenses with NC for Belgium, Finland, France, Guatemala, Italy, Japan, Luxembourg, Netherlands, and Spain.

mzeinstra commented Aug 16, 2018

Can we fix this? It has been almost 6 months since I reported that second logo left to non-commercial has a duplicate image.

It seems to occur when the NC wants to display the currency of the area (e.g. Euro or the Japanese Yen) in the old design but the dollar in the new design.

It is due to this file: https://github.com/creativecommons/creativecommons.org/blob/master/docroot/includes/jurisdictions.css
and occurs on the licenses with NC for Belgium, Finland, France, Guatemala, Italy, Japan, Luxembourg, Netherlands, and Spain.

@robmyers

This comment has been minimized.

Show comment
Hide comment
@robmyers

robmyers Aug 16, 2018

Contributor

@robinpuga was this a conscious decision? I forget.

Contributor

robmyers commented Aug 16, 2018

@robinpuga was this a conscious decision? I forget.

@mzeinstra

This comment has been minimized.

Show comment
Hide comment
@mzeinstra

mzeinstra Aug 16, 2018

I think it was never taken as a feature for the new designs of the new deed pages and is an artifact of the older ones. I like the feature, but I can imagine that it overcomplicates. I suggest removing the reference to that css file on the deed page and create a feature request to re-introduce these icons based on their respective currency.

mzeinstra commented Aug 16, 2018

I think it was never taken as a feature for the new designs of the new deed pages and is an artifact of the older ones. I like the feature, but I can imagine that it overcomplicates. I suggest removing the reference to that css file on the deed page and create a feature request to re-introduce these icons based on their respective currency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment