Join GitHub today
French Deeds 2.5 and 3.0 are 404ing #732
Via Slack: https://creativecommons.org/licenses/by-nc/2.5/legalcode.fr
We don't have 2.5 fr legalcode in Git, only 2.0 and 3.0 . Search in the page here for 2.0_fr, 2.5_fr and 3.0_fr to confirm this:
The 3.0 are currently working for me, e.g.:
If anyone is still having trouble with the 3.0 licenses, please can they provide the url that is causing the error, and the error that their web browser reports.
Here are all the broken links:
All these links have been accessed through the same process, and display to me a 404 error:
The requested URL /licenses/by-nd/2.5/legalcode.fr was not found on this server.
Here are the links that are 404'd again to me:
All these pages display to me the following error, where XXX is the licence:
The requested URL /licenses/XXX/3.0/fr/legalcode.fr was not found on this server.
Thank you for providing this information.
There are two different bugs here.
The French 2.5 deeds do not have accompanying French legalcode documents. I am not sure whether this means that we should not display the French 2.5 deeds or whether they should link to the un-ported licenses. @peterspdx what is the correct approach here?
The French 3.0 deeds do have ported legalcode documents. We should therefore link to them. We are currently serving them without a language code extension, e.g.:
Both the path and the extension work for 4.0:
The former ( /fr/ ) is incorrect for 4.0 because the 4.0 versions do not have ports, the latter ( .fr ) is correct for 4.0 but would be incorrect for 3.0 as it appears here because 3.0 does not have translations of the un-ported licenses. i.e. we would not expect this to work:
Now, we cannot assume that each ported license has a single legalcode. For example 2.0.be has two different translations:
Nobody links to /2.0/be/legalcode without a language code:
But, likewise, nobody links to /3.0/fr/legalcode with a language code:
So the /3.0/fr/legalcode.fr links are incorrect and we have to fix this.
@peterspdx I'm sorry to tag you twice in one issue but does this sound right?
We have an issue open for this and I am working on it but it has proven to be a surprisingly complex problem. Working through this has been very helpful, so thank you @ArgyroNe7 for reporting this. I am hoping to be able to fix this in the next couple of weeks but I have a couple of project launches to get out of the way first unfortunately.
On bug #1, the 2.5 French deeds should link to the 2.5 English unported licenses. That's useful for Francophones who are using any 2.5 licenses and want to read the human readable summary in their preferred language.
On bug #2: