New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon on deed and license pages looks pixelated #819

Open
ericsteuer opened this Issue Jun 19, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@ericsteuer

ericsteuer commented Jun 19, 2018

compared to other pages across cc.org, the favicon on deed and license pages looks pretty pixelated / blurry

i.e. https://creativecommons.org/licenses/by/4.0/

here is a screen grab of two tabs open in my browser. one is cc by 4.0 deed page and the other is the cc homepage:
screen shot 2018-06-19 at 8 59 25 am

would be nice to update these soon, since we're pushing new deed and license pages out soon. adding @robinpuga to this in case it's something that can more easily be done by the AB team in tandem with the new design push?

@little-wow

This comment has been minimized.

Contributor

little-wow commented Jun 22, 2018

changed the dimensions to 512x512, should be fixed?

@little-wow little-wow closed this Jun 22, 2018

@ericsteuer

This comment has been minimized.

ericsteuer commented Jul 9, 2018

still pixelated when i view it (in chrome, on mac)
https://creativecommons.org/licenses/by/4.0/
screen shot 2018-07-09 at 12 25 53 pm

@ericsteuer ericsteuer reopened this Jul 9, 2018

@robmyers

This comment has been minimized.

Contributor

robmyers commented Jul 9, 2018

We don't specify the Apple (etc.) icon in the Python templates.

Doing so won't alter the meaning of the pages, so we can copy the relevant code from the WordPress theme to the Python templates.

@little-wow

This comment has been minimized.

Contributor

little-wow commented Jul 9, 2018

Rob, the WP one was fixed

@robmyers

This comment has been minimized.

Contributor

robmyers commented Jul 9, 2018

It should have been OK since the New Site deployment? The Python site gets its image and style assets from the WordPress site but we have to tell browsers where to look, and I don't think the Python site does atm. I could be wrong (or people's browsers could be being smarter than me...) :-) .

@mackh

This comment has been minimized.

mackh commented Aug 22, 2018

Seems there is more work to do on this to get it looking right on Mac Chrome, we'll work on it

@robmyers robmyers removed their assignment Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment