Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in code on new license/legal code pages #835

Closed
ericsteuer opened this Issue Jul 12, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@ericsteuer
Copy link

ericsteuer commented Jul 12, 2018

i got a private message in slack about a couple of code errors that are showing up on the new legal code pages. the user was viewing in chrome. see attached.
image

@little-wow

This comment has been minimized.

Copy link
Contributor

little-wow commented Jul 12, 2018

I'm getting different errors in console, can't replicate these.

@robmyers

This comment has been minimized.

Copy link
Contributor

robmyers commented Jul 13, 2018

skip-link-focus-fix is in the TwentySixteen WordPress theme and can be accessed OK.

The second one is weird, I don't think we should be saving any data blobs. @robinpuga ?

@altrugon

This comment has been minimized.

Copy link
Contributor

altrugon commented Jul 24, 2018

The skip-link-focus-fix.js error was due to an extra line of code left behind on the copy/paste procedure from the website theme. I have solved the issue by removing the line below:

<script type='text/javascript' src='//wp-content/themes/twentysixteen/js/skip-link-focus-fix.js'></script>

From creativecommons.org/tools/legalcode-includes/html-head.html and then run the update_cc4_includes.py update script.

For the second error I have to say that I haven't been able to reproduce it on any browser. It's complaining about a missing file, perhaps it's related to the first error, if that is not the case it would help me if the person experiencing this error would click on it and show me the complaining line of code.

The solution for this ticket is on branch feature/js-errors remote https://github.com/creativecommons/creativecommons.org.git.

@robmyers

This comment has been minimized.

Copy link
Contributor

robmyers commented Aug 9, 2018

I have merged and deployed the fix (thank you @altrugon !).

Loading the page now gives me no errors in the console.

@ericsteuer can you check this and see if the other errors were indeed related?

Thank you everyone!

@robmyers robmyers removed their assignment Sep 7, 2018

@kgodey

This comment has been minimized.

Copy link
Member

kgodey commented Mar 15, 2019

Fixed per @ericsteuer on Slack.

@kgodey kgodey closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.