Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on chapter sites do not work yet – no search page implemented #16

Closed
mzeinstra opened this issue Apr 29, 2019 · 3 comments
Closed
Assignees

Comments

@mzeinstra
Copy link

The new archive page allows users to search through the posts, however there is no search page available yet.

See: https://nl-beta.creativecommons.org/?search=Open+Access

@hugosolar
Copy link
Contributor

The wordpress default search works with the s parameter
the search you refer should be like this
https://nl-beta.creativecommons.org/?s=Open+Access
I use the search parameter only in the post archive to avoid conflicts with the default wordpress search
does that make sense to you?

@mzeinstra
Copy link
Author

Makes sense to me.

When I usesd the ?search query I did not find anything. Now I do.

However this is not implemented throughout.

Compare:
https://nl-beta.creativecommons.org/news-temp/ (page template)
with
https://nl-beta.creativecommons.org/nieuws/ build in 'post page'

the latter has no search, the former has.

Maybe I am misusing the issue now :)

@hugosolar
Copy link
Contributor

haha don't worry.
I added the filter to the 'post page' in 72dffa4

@kgodey kgodey added this to the Chapter Websites Beta milestone Apr 29, 2019
@kgodey kgodey added the bug label Apr 29, 2019
@kgodey kgodey closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants