fix: Fix coercion of i64 keys in map #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-greene-ck
requested review from
kevin-greene-ck and
ramakrishna-battala-ck
|
Thanks @hayes these are much appreciated. We definitely have BigInts in our future plans. |
kevin-greene-ck
approved these changes
Nov 25, 2018
|
@hayes Both of your PRs are released in |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds coercion for map keys when initializing a struct (for thrift-server).
Previously thrift files which defined a struct containing a map who's keys are i64s would generate invalid typescript. The args would contain a map with keys of type
number | thrift.Int64, and would attempt to set values on aMap<thrift.Int64, {valueType}>.Having object keys in maps for a scalar type is not ideal, but I think this fix is a good interim solution. In the long run it would be awesome if i64s could be represented as BigInts now that they are supported in typescript and an LTS version of node.