New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file readability check, as requested in [cpan #99055] #4

Merged
merged 1 commit into from Nov 12, 2015

Conversation

Projects
None yet
3 participants
@moritz
Contributor

moritz commented Jan 1, 2015

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jan 23, 2015

This change has no tests?

karenetheridge commented Jan 23, 2015

This change has no tests?

@moritz

This comment has been minimized.

Show comment
Hide comment
@moritz

moritz Jan 23, 2015

Contributor

No, I don't know how to make files non-readable in a cross-platform way. Suggestions welcome, though I don't know if it's worth it, given that it's a rather simple change (and the old feature didn't have tests either).

Contributor

moritz commented Jan 23, 2015

No, I don't know how to make files non-readable in a cross-platform way. Suggestions welcome, though I don't know if it's worth it, given that it's a rather simple change (and the old feature didn't have tests either).

crenz added a commit that referenced this pull request Nov 12, 2015

Merge pull request #4 from moritz/remove-readability-check-rt-99055
Remove file readability check, as requested in [cpan #99055]

@crenz crenz merged commit 44e6f7d into crenz:master Nov 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment