GHC-7.6.1 compatibility on Windows 7 #72

Merged
merged 5 commits into from Oct 19, 2012

Conversation

Projects
None yet
3 participants
@elliottt
Collaborator

elliottt commented Oct 16, 2012

This patch includes the following changes:

  • Expand package ranges to allow ghc-7.6.1 on Windows 7 to build
  • Update the source to include an import of catch from Control.Exception when ghc-7.6.1 is detected
  • Remove some unused imports
  • Upgrade to using tar >= 0.4, as that allows the directory version shipped with ghc-7.6.1 to work. Of all the changes, this is likely to be the most controversial, though I think we can work around it with CPP if it comes to that.
@elliottt

This comment has been minimized.

Show comment Hide comment
@elliottt

elliottt Oct 16, 2012

Collaborator

Looks like there are some other patches in the queue that do just about the same thing as mine. I think that the Win32 changes, and the warning removal are unique, but the rest might be repeated by other pull requests.

Collaborator

elliottt commented Oct 16, 2012

Looks like there are some other patches in the queue that do just about the same thing as mine. I think that the Win32 changes, and the warning removal are unique, but the rest might be repeated by other pull requests.

@RubenAstudillo

This comment has been minimized.

Show comment Hide comment
@RubenAstudillo

RubenAstudillo Oct 18, 2012

I like more your aproach. You respect upper-bounds and the CPP trick to catch seems the way to go to handle the different catch functions.

I will use your patches instead of mine :), hope this get merged soon

I like more your aproach. You respect upper-bounds and the CPP trick to catch seems the way to go to handle the different catch functions.

I will use your patches instead of mine :), hope this get merged soon

@jtdaugherty

This comment has been minimized.

Show comment Hide comment
@jtdaugherty

jtdaugherty Oct 19, 2012

Contributor

After reviewing all of the pull requests for this issue, I'm going to merge this one as it addresses the backwards compatibility issue I cited elsewhere. I think it would be helpful for us to decide on a backwards compatibility policy to make changes like this easier to assess; "always working with the most recent GHC only" is not, IMHO, a viable long-term strategy for this package. Thanks to the others who have put effort into resolving this, and sorry for the delay on getting it merged!

Contributor

jtdaugherty commented Oct 19, 2012

After reviewing all of the pull requests for this issue, I'm going to merge this one as it addresses the backwards compatibility issue I cited elsewhere. I think it would be helpful for us to decide on a backwards compatibility policy to make changes like this easier to assess; "always working with the most recent GHC only" is not, IMHO, a viable long-term strategy for this package. Thanks to the others who have put effort into resolving this, and sorry for the delay on getting it merged!

jtdaugherty added a commit that referenced this pull request Oct 19, 2012

Merge pull request #72 from elliottt/master
GHC-7.6.1 compatibility on Windows 7, with CPP for backwards compat for previous versions

@jtdaugherty jtdaugherty merged commit 81fb932 into creswick:master Oct 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment