Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix StreamIndexOutOfBoundsError w/null value (0xFFFF val.length) #34

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

I assume a nullable column with a value's length of 0xFFFF should actually become null (see #33). The length is set based on emptyPossible so that is does not break the logic in the isNull method and returns a null value (instead of an empty string).

I do not know if a length of 0xFFFF should always be null or perhaps only for uint16LE length type or VarChar sql types. I would appreciate it if anyone could check this.

Sorry I don't have any tests.

@martijndeh martijndeh Update src/row.token.coffee
I assume a nullable column with a value's length of 0xFFFF should actually become null (see #33). The length is set based on emptyPossible so that is does not break the logic in the isNull method.

I do not know if a length of 0xFFFF should always be null or perhaps only for uint16LE length type or VarChar sql types. I would appreciate it if anyone could check this.
08ad464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment