Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Subject ID attribute support #454

merged 1 commit into from Jan 12, 2023


Copy link

@hf hf commented Aug 14, 2022

Add support for the SAML V2.0 Subject Identifier Attributes Profile Version 1.0 which supersedes persistent NameID.

Additionally, adds support for passing in a different NameIDFormat.

@hf hf mentioned this pull request Aug 14, 2022
@hf hf force-pushed the hf/add-subject-id-attribute branch from 77448f8 to a4b7ee2 Compare August 14, 2022 18:08
@hf hf force-pushed the hf/add-subject-id-attribute branch from a4b7ee2 to 28f5bcf Compare August 14, 2022 18:51
Copy link

Fixes #441

Copy link

Hi @hf, we ran into this issue as well. Thanks for putting together this PR! In the meantime, we're using the workaround of having a custom AssertionMaker in our IdentityProvider that first calls DefaultAssertionMaker.MakeAssertion(), and then patches values we'd like to change before returning.

@crewjam crewjam merged commit f98e759 into crewjam:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants