Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postInjectionHook is not being used #5

Closed
jusopi opened this issue Jul 9, 2014 · 2 comments
Closed

postInjectionHook is not being used #5

jusopi opened this issue Jul 9, 2014 · 2 comments

Comments

@jusopi
Copy link

jusopi commented Jul 9, 2014

the injectInto method is not making use of the postInjectionHook prop. Rather it's hardcoded to "setup".

ref - line 377 ./src/dijon.js

@jusopi
Copy link
Author

jusopi commented Jul 9, 2014

I've created and tested this. Here is the fix for this issue:

if ( this.postInjectionHook in instance )
    instance[this.postInjectionHook].call( instance );

@creynders
Copy link
Owner

Thanks, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants