Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-request] could crictl pull verify tags via Docker Content Trust conception? #2065

Closed
Slach opened this issue Feb 9, 2019 · 4 comments

Comments

@Slach
Copy link

Slach commented Feb 9, 2019

does cri-o support Docker Content Trust conception descibed here
https://docs.docker.com/engine/security/trust/content_trust/?
could i set "use only trusted images" when use crio?

@Slach Slach changed the title [question] does could crictl pull verify tags via Docker Content Trust conception? [question] could crictl pull verify tags via Docker Content Trust conception? Feb 9, 2019
@Slach Slach changed the title [question] could crictl pull verify tags via Docker Content Trust conception? [Feature-request] could crictl pull verify tags via Docker Content Trust conception? Feb 9, 2019
@mrunalp
Copy link
Member

mrunalp commented Feb 11, 2019

@mtrmac Could you take this one?

@mtrmac
Copy link
Collaborator

mtrmac commented Feb 11, 2019

CRI-O does not integrate with Notary currently.

I haven’t looked at Notary for some time, so the design might have changed; but integrating Notary into the daemon would be possible in principle but somewhat intrusive.

Notary integrates into image use by replacing the tag references with digest references. To work correctly and consistently, that would ideally need to be done by integrating Notary support all the way down in c/image/docker so that it is completely transparent to callers referring to images by tags — forcing Notary integration, or at least vendoring of the code including the crypto implementations, on all c/image/docker users.

Then we would have to define some new mechanism (not present in Docker AFAICT!) to enable/disable Notary use per-registry: A global on/off switch is not really viable for a daemon unless you expect all images on the cluster to live on the Docker Hub (or maybe a single private registry), and CRI requests never to refer to images on other registries.


(Or, well, it could be done the Docker-CE way and literally implement what the title of the issue says, doing that in crictl pull but not in the CRI-O daemon, i.e. making Notary enforcement unavailable to Kubernetes. Equivalently, a shell wrapper around crictl and the notary command could do that. But I expect that the goal is actually to benefit Kubernetes, not the very rare manual uses of crictl.)

@rhatdan
Copy link
Contributor

rhatdan commented Feb 12, 2019

We don't control crictl or Kubernetes. So this issue should go to those projects. If you want Notary signing to work, I believe it needs to be implemented in the orchestrator not in the CRIs. If people want to work on making this work with something like podman or buildah we could look at the PRs

@rhatdan
Copy link
Contributor

rhatdan commented Mar 18, 2019

Since this issue needs to be with Kubernetes, closing.

@rhatdan rhatdan closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants