Allow to override build date with SOURCE_DATE_EPOCH

[bmwiedemann]

- What I did
Make cri-o build reproducibly by default.

- How I did it
Default BUILD_INFO to SOURCE_DATE_EPOCH, if available.

- How to verify it

1. export SOURCE_DATE_EPOCH=123456
2. Do 2 clean builds within taskset 1 (needed because of some go parallelism bug) and compare /usr/bin/crio - should have identical content between builds.

- Description for the changelog
Allow to override build date with SOURCE_DATE_EPOCH

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

While it is already possible to do reproducible builds without
this patch, this patch makes it the default,
so that distributions do not have to discover the BUILD_INFO variable.

Without this patch, /usr/bin/crio differs in ELF section .note.go.buildid

Signed-off-by: Bernhard M. Wiedemann bwiedemann@suse.de

[openshift-ci-robot]

Hi @bmwiedemann. Thanks for your PR.

I'm waiting for a cri-o or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

Hi @bmwiedemann. Thanks for your PR.

I'm waiting for a cri-o or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bmwiedemann]

/assign @rhatdan

[codecov]

Codecov Report

Merging #2643 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2643   +/-   ##
=======================================
  Coverage   53.11%   53.11%           
=======================================
  Files          82       82           
  Lines        6979     6979           
=======================================
  Hits         3707     3707           
  Misses       2911     2911           
  Partials      361      361

[haircommander]

/ok-to-test
Change LGTM, though i'd almost prefer to replace the BUILD_INFO variable with SOURCE_DATE_EPOCH and set it with
SOURCE_DATE_EPOCH ?= $(shell date +%s)

[saschagrunert]

Hey @bmwiedemann 👋, thanks for the improvement. I agree with @haircommander and I think we can replace the $(BUILD_INFO) variable entirely.

[saschagrunert]

/test integration_rhel

[saschagrunert]

LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmwiedemann, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmwiedemann, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm

[saschagrunert]

/test integration_rhel

[saschagrunert]

/test integration_rhel

[bmwiedemann]

hmm, does the integration test rely on BUILD_INFO somehow?

[saschagrunert]

hmm, does the integration test rely on BUILD_INFO somehow?

No, we have some flakes in the integration tests which we will tackle in the future 😇