[1.17] Revert "infra: remove unneeded uses of infra container" #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
dco-signoff: yes
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
added
size/L
haircommander
force-pushed
the
revert-infra-remove
branch
from
c812bd1
to
9dc1a4d
Compare
openshift-ci-robot
removed
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
needs rebase |
|
LGTM assuming happy tests |
haircommander
force-pushed
the
revert-infra-remove
branch
from
9dc1a4d
to
25d294c
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.17 #3183 +/- ##
================================================
+ Coverage 44.8% 44.92% +0.11%
================================================
Files 90 90
Lines 7584 7569 -15
================================================
+ Hits 3398 3400 +2
+ Misses 3890 3875 -15
+ Partials 296 294 -2 |
|
/test e2e-aws |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/lgtm |
|
/test e2e-aws |
|
/test e2e-aws |
|
/test kata-containers |
|
/test kata-containers |
|
/test launch-aws |
This reverts commit 1d7d971. This revert is needed because 1.17 is not ready to remove infra containers, and this code is incomplete (the Ready() check wasn't correct). as such, revert it until we actually drop the infra container Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
revert-infra-remove
branch
from
25d294c
to
5a5fa81
Compare
|
/retest |
|
/test e2e-aws |
|
/lgtm |
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d7d971.
This revert is needed because 1.17 is not ready to remove infra containers, and this code is incomplete (the Ready() check wasn't correct). as such, revert it until we actually drop the infra container
Signed-off-by: Peter Hunt pehunt@redhat.com