Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: disable fdatasync() for atomic writes and bump c/storage to v1.19.2 #3747

Merged
merged 2 commits into from May 13, 2020
Merged

storage: disable fdatasync() for atomic writes and bump c/storage to v1.19.2 #3747

merged 2 commits into from May 13, 2020

Conversation

giuseppe
Copy link
Member

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

drop unuseful fdatasync calls

Which issue(s) this PR fixes:

fewer writes to the disk

Special notes for your reviewer:

I am vendoring a custom containers/storage branch (github.com/giuseppe/storage no-sync).

PR for containers/storage: containers/storage#620

Does this PR introduce a user-facing change?

NONE

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2020
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

1 similar comment
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels May 11, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020 •
edited

Codecov Report

Merging #3747 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3747   +/-   ##
=======================================
  Coverage   40.31%   40.31%           
=======================================
  Files         105      105           
  Lines        8665     8665           
=======================================
  Hits         3493     3493           
  Misses       4861     4861           
  Partials      311      311

@giuseppe giuseppe force-pushed the no-sync branch 2 times, most recently from d2a9472 to 705b05a Compare May 11, 2020 08:53
@giuseppe giuseppe marked this pull request as ready for review May 11, 2020 12:57
@giuseppe giuseppe requested a review from runcom as a code owner May 11, 2020 12:57
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2020
@giuseppe
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 11, 2020
@giuseppe giuseppe changed the title storage: disable fdatasync() for atomic writes [HACK][WIP] storage: disable fdatasync() for atomic writes May 11, 2020
@haircommander
Copy link
Member

/retest

@giuseppe
Copy link
Member Author

/test e2e_crun

@mrunalp
Copy link
Member

mrunalp commented May 11, 2020

@giuseppe mind opening a release-1.18 PR to get e2e-aws run data as well? Thanks!

@giuseppe
Copy link
Member Author

@giuseppe mind opening a release-1.18 PR to get e2e-aws run data as well? Thanks!

opened here: #3750

@giuseppe
vendor: update containers/storage to v1.19.2
a02f217 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
container_server: disable fdatasync() for atomic writes
92f9f68 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe changed the title [HACK][WIP] storage: disable fdatasync() for atomic writes storage: disable fdatasync() for atomic writes May 13, 2020
@giuseppe
Copy link
Member Author

/retest

@giuseppe
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@TomSweeneyRedHat
Copy link
Contributor

Changes LGTM. If you could add "Bump c/storage to v1.19.2" or some such to the title, that would be appreciated.

@giuseppe
Copy link
Member Author

how to restart circleci?

@giuseppe giuseppe changed the title storage: disable fdatasync() for atomic writes storage: disable fdatasync() for atomic writes and bump c/storage to v1.19.2 May 13, 2020
@haircommander
Copy link
Member

retriggered

@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5110b9d into cri-o:master May 13, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander Awaiting requested review from haircommander

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@mrunalp mrunalp Awaiting requested review from mrunalp

@sameo sameo Awaiting requested review from sameo

@runcom runcom Awaiting requested review from runcom

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@giuseppe @openshift-ci-robot @haircommander @mrunalp @TomSweeneyRedHat @openshift-merge-robot