name is reserved: give more informative error #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if cri-o perfectly cleans up its state after failures, name is reserved errors are still possbile. Mainly: when cri-o times out attempting to provision networking or disk resources. Given this is the most likely scenerio, print this as a debug message, rather than the cryptic "name is reserved" Signed-off-by: Peter Hunt <pehunt@redhat.com>
openshift-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
mrunalp
reviewed
Jul 22, 2020
| @@ -529,7 +529,7 @@ func (s *Server) CreateContainer(ctx context.Context, req *pb.CreateContainerReq | |||
| } | |||
|
|
|||
| if _, err = s.ReserveContainerName(ctr.ID(), ctr.Name()); err != nil { | |||
| return nil, errors.Wrap(err, "reserving container name") | |||
| return nil, errors.Wrap(err, "Kubelet may be retrying requests that are timing out in CRI-O due to system load") | |||
There was a problem hiding this comment.
We should retain the original error. Is it contained in the wrapped err?
There was a problem hiding this comment.
yeah it says error reserving pod name %s for id %s: %v or container
/retest |
Codecov Report
@@ Coverage Diff @@
## master #4002 +/- ##
=======================================
Coverage 40.76% 40.76%
=======================================
Files 109 109
Lines 8876 8876
=======================================
Hits 3618 3618
Misses 4928 4928
Partials 330 330 |
|
/lgtm |
|
/retest |
|
LGTM |
|
/test integration_rhel |
|
|
/retest |
|
/test e2e-aws |
|
LGTM |
|
/test e2e-aws |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
even if cri-o perfectly cleans up its state after failures, name is reserved errors are still possbile.
Mainly: when cri-o times out attempting to provision networking or disk resources.
Given this is the most likely scenerio, print this as a debug message, rather than the cryptic "reserving * name"
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?