Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.20] Bug 1881694 Add pull source as info level log #4536

Merged
merged 1 commit into from Feb 24, 2021

Conversation

QiWang19
Copy link
Contributor

@QiWang19 QiWang19 commented Feb 2, 2021

Signed-off-by: Qi Wang qiwan@redhat.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1881694
This BZ needs change the log level of the image pull location from the debug to info.
Crio could use SystemContext.DockerLogPullSource to log the physical image source if it's from a mirror.

Which issue(s) this PR fixes:

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1881694

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Crio adds info level log of the physical image source.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1881694
This BZ needs change the log level of the image pull location from the debug to info.
Crio could use SystemContext.DockerLogPullSource to log the physical image source if it's from a mirror.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 2, 2021
@QiWang19 QiWang19 changed the title Bug: 1881694 Add pull source as info level log [release-1.20] Bug 1881694 Add pull source as info level log Feb 2, 2021
@QiWang19
Copy link
Contributor Author

QiWang19 commented Feb 2, 2021

/retest

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #4536 (7010eed) into release-1.20 (2bd5fcd) will decrease coverage by 0.04%.
The diff coverage is 15.38%.

@@               Coverage Diff                @@
##           release-1.20    #4536      +/-   ##
================================================
- Coverage         40.54%   40.50%   -0.05%     
================================================
  Files               117      117              
  Lines              9422     9434      +12     
================================================
+ Hits               3820     3821       +1     
- Misses             5173     5183      +10     
- Partials            429      430       +1     

@haircommander
Copy link
Member

/approve

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@haircommander
Copy link
Member

/retest

3 similar comments
@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

/retest

@QiWang19
Copy link
Contributor Author

/test integration_crun

@QiWang19
Copy link
Contributor Author

/test integration_fedora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants