Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.19] hostport manager clean up host ports #4800

Merged
merged 1 commit into from Apr 27, 2021
Merged

[release-1.19] hostport manager clean up host ports #4800

merged 1 commit into from Apr 27, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4542

/assign haircommander

NONE

hostport manager clean up host ports
291b183 
The host port manager, when removing hostports, exists fast if
there are no iptables rules to delete.
However, it was missing to call the method that remove the
hostports bound, so there is a possibility that we leak sockets.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 23, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2021
Merged
@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2021
@haircommander
Copy link
Member

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Apr 23, 2021

/lgtm

@nee1esh
Copy link

nee1esh commented Apr 23, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2021 •
edited

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 291b183 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Apr 24, 2021 via email

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2021
@haircommander
Copy link
Member

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

fixed in #4814

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2021
@openshift-ci-robot
Copy link

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

In response to this:

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

fixed in #4814

/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 483f47a into cri-o:release-1.19 Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @haircommander @openshift-ci-robot @mrunalp @nee1esh @openshift-merge-robot