Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22] [release-1.23] server: Canonize selinux label for comparison with filesystem label #5829

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5792

/assign haircommander

Fixed `io.kubernetes.cri-o.TrySkipVolumeSELinuxLabel` annotation usage with the OpenShift MCS.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 27, 2022
@openshift-ci openshift-ci bot requested a review from giuseppe April 27, 2022 15:01
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #5829 (6d0302f) into release-1.22 (7cf77a9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 6d0302f differs from pull request most recent head 82206c6. Consider uploading reports for the commit 82206c6 to get more accurate results

@@               Coverage Diff                @@
##           release-1.22    #5829      +/-   ##
================================================
- Coverage         43.78%   43.78%   -0.01%     
================================================
  Files               120      120              
  Lines             11846    11850       +4     
================================================
+ Hits               5187     5188       +1     
- Misses             6168     6171       +3     
  Partials            491      491              

Signed-off-by: Manuel Luis Sanmartín Rozada <manuel.luis@gmail.com>
…nux label

Signed-off-by: Manuel Luis Sanmartín Rozada <manuel.luis@gmail.com>
@haircommander haircommander force-pushed the cherry-pick-5792-to-release-1.22 branch from b72fdc2 to 82206c6 Compare May 4, 2022 14:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 b72fdc2 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 388405c into cri-o:release-1.22 May 4, 2022
@haircommander
Copy link
Member

/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #5873

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants