Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] [release-1.23] server: Canonize selinux label for comparison with filesystem label #5873

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5829

/assign haircommander

Fixed `io.kubernetes.cri-o.TrySkipVolumeSELinuxLabel` annotation usage with the OpenShift MCS.

Signed-off-by: Manuel Luis Sanmartín Rozada <manuel.luis@gmail.com>
…nux label

Signed-off-by: Manuel Luis Sanmartín Rozada <manuel.luis@gmail.com>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 13, 2022
@openshift-ci openshift-ci bot requested review from giuseppe and umohnani8 May 13, 2022 20:16
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #5873 (6cb6bf7) into release-1.21 (8faeccb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.21    #5873      +/-   ##
================================================
- Coverage         45.01%   45.00%   -0.02%     
================================================
  Files               109      109              
  Lines             11053    11057       +4     
================================================
  Hits               4976     4976              
- Misses             5598     5602       +4     
  Partials            479      479              

@haircommander
Copy link
Member

/retest
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 6cb6bf7 link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 6cb6bf7 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d3132c4 into cri-o:release-1.21 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants