-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCI artifact seccomp profiles #7719
Add support for OCI artifact seccomp profiles #7719
Conversation
14353fb
to
f221361
Compare
|
/retest |
e001632
to
a86a6f8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7719 +/- ##
==========================================
+ Coverage 47.95% 48.05% +0.09%
==========================================
Files 146 148 +2
Lines 16274 16339 +65
==========================================
+ Hits 7804 7851 +47
- Misses 7517 7532 +15
- Partials 953 956 +3 |
26e81b7
to
dafe655
Compare
|
I'm going to blog about this, for now it's ready for review. PTAL @cri-o/cri-o-maintainers |
|
/test ci-fedora-kata |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ci-fedora-kata |
dafe655
to
cc9b5cb
Compare
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
Eesh. We're still lacking a mapping or documented convention about how the annotations get set on containers when they start out on a Kubernetes Pod (Kubernetes uses a different convention). I commented on this in https://github.com/kubernetes/website/pull/45121/files#r1487723768 |
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This blog post wraps the efforts around a future CRI-O feature implemented in PR: cri-o/cri-o#7719 Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Tim Bannister <tim@scalefactory.com> Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This feature allows pulling seccomp profiles using OCI artifacts directly within CRI-O.
The new annotation
seccomp-profile.kubernetes.cri-o.iocan be used to:podman build \ --annotation seccomp-profile.kubernetes.cri-o.io/POD=quay.io/crio/seccomp:v1 \ -t quay.io/crio/nginx-seccomp .The profile itself can be pushed into a registry using the ORAS CLI, for example by running:
The resulting image manifest looks like this:
{ "schemaVersion": 2, "mediaType": "application/vnd.oci.image.manifest.v1+json", "config": { "mediaType": "application/vnd.oci.image.config.v1+json", "digest": "sha256:ca3d163bab055381827226140568f3bef7eaac187cebd76878e0b63e9e442356", "size": 3 }, "layers": [ { "mediaType": "application/vnd.oci.image.layer.v1.tar", "digest": "sha256:c15f3eb1efd9abe0ae973e050c374988bba52c45a53f5c3cd80419a865013fa6", "size": 20480, "annotations": { "org.opencontainers.image.title": "seccomp.tar" } } ], "annotations": { "org.opencontainers.image.created": "2024-02-05T11:37:22Z" } }Authentication with registries during artifact pull is out of scope of this PR.
Which issue(s) this PR fixes:
Fixes #7580
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?