Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hot-words): remove daily hot words of urban dict #1428

Merged
merged 3 commits into from
Aug 9, 2021
Merged

fix(hot-words): remove daily hot words of urban dict #1428

merged 3 commits into from
Aug 9, 2021

Conversation

yipanhuasheng
Copy link
Contributor

方案是去除urban词典查询结果中,固定在第二个的每日热词,其他词典默认不处理

@crimx
Copy link
Owner

crimx commented Aug 9, 2021

谢谢你的 PR。这里处理的地方不太正确。urban 词典相关的应该只需动 /src/components/urban/engine.ts

@crimx
Copy link
Owner

crimx commented Aug 9, 2021

components/DictItem/ 是所有词典共用的展示组件,不会处理某个词典特有的逻辑。

@yipanhuasheng
Copy link
Contributor Author

大概了解啥情况了,单个词典的逻辑都在engine.ts,所以要在这里处理result吧

@crimx crimx merged commit 5dc29cd into crimx:dev Aug 9, 2021
@crimx
Copy link
Owner

crimx commented Aug 9, 2021

对哒!合啦!👍🏻

@Retia-Adolf
Copy link

Urban dict 的词条赞/踩数没有了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants