corrects readme and fixes headers not being written correctly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! @patrickjmcd you are totally right! I forgot to update the Docs. Thanks for your PR! |
|
You’re quite welcome! I’m glad it helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command to run the script with a non-default port needed to be
./gochain -port=5000instead of./gochain 5000.Also, in order for the HTTP response to be encoded correctly, in the buildResponse function,
w.Header().Set("Content-Type", "application/json")needs to come beforew.WriteHeader(resp.statusCode)