Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS selector modification support #4

Closed
o0101 opened this issue Sep 16, 2018 · 2 comments
Closed

Improve CSS selector modification support #4

o0101 opened this issue Sep 16, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@o0101
Copy link
Owner

o0101 commented Sep 16, 2018

The issue is, there are some complex types of selectors that our simple selector parsing implementation (used to determine the proper insertion point for the unique class to scope the rule) will not work on.

It's an enhancement to be able to support these types as well.

@o0101 o0101 added the enhancement New feature or request label Sep 16, 2018
@o0101 o0101 changed the title Improve CSS selector parsing Improve CSS selector modification support Sep 16, 2018
@o0101
Copy link
Owner Author

o0101 commented Sep 16, 2018

For instance, we need to be able to handle (and currently I think we do not), the types of selectors illustrated by the following examples:

:matches(tagone, tagtwo, tagthree) { 
  /* we will incorrectly separate on the commas and spaces */
}
[attr="value" i] { 
  /* we will incorrectly insert on the first space before the i */
}
@directive keyword and (attribute: value) {
  selector {
    /* we will not modify 'selector' here because we ignore CSSRules without type == STYLE_RULE */
  }
}

@o0101
Copy link
Owner Author

o0101 commented Oct 25, 2018

Facing the issue of not working with media queries yet.

The holygrail layout component introduced in https://github.com/crislin2046/brutestrap/commit/510dbcbfb39e8c67bc395e6772b2900571556336

will not be responsive because the media rules set for it are ignored by C3S.

@o0101 o0101 added the help wanted Extra attention is needed label Jan 26, 2019
@o0101 o0101 closed this as completed in 3be1b79 Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant