New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) vendor prefixing #9
Comments
If it's needed, then please have it made as a separate plugin, |
Hey @imlinus, that's a great idea! 😃 Thanks for your feedback! |
Alrighty! 😄 So, it's been a couple of fun weeks. I've rewritten the css parser and all the under the hood compilation and I've managed to get the proper css support and generation - right now there are some corner cases, I believe. With that in mind, what other libraries are doing, are using either https://github.com/thysultan/stylis.js or they make a case for post processing the statically extracted css. The part with statically extracted css, is really something that sounds great, but in the end it's not really. Max, the co-author of styled-components, has recently published this article(https://mxstbr.com/thoughts/css-in-js/) which goes into the exact issue. So, bottom line, for now I think it's the user choice to include the proper vendor prefixing. If I were to add this feature, as you said, the size would increase dramatically and it'll be really hard to pick what to prefix or not. Let me know what you think and feel free to open the ticket, again. |
Great library! I like the idea of a plugin or additional module which includes the option. We use currently use styled-components, and it is nice not to have to worry about adding them all over. Perhaps it could work with https://github.com/browserslist/browserslist to determine which prefixes are needed. |
I think a separate, pluggable, package for I'll reopen it, and see where it leads. |
Sounds good! <my-two-cents> |
This should be implemented now for v2, I'll add some integration tests this weekend. |
Figure out of this feature is needed
The text was updated successfully, but these errors were encountered: