New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation of HNPWA-vanilla documentation #11

Merged
merged 3 commits into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@satyakresna
Contributor

satyakresna commented Feb 10, 2018

Hi Cristian, I just try update installation of HNPWA-vanilla documentation. You can try in local. If it runs well, please let me know. Thanks a lot.

@cristianbote

This comment has been minimized.

Owner

cristianbote commented Feb 12, 2018

Hey @satyakresna,

Thank you! 😄 This clears up the confusing parts of running it locally, for sure. I need to check something first, because I think you can do it via firebase-cli and don't need to have the python installed.

I'll get back to you.
Thanks again!

@cristianbote cristianbote self-assigned this Feb 12, 2018

@satyakresna

This comment has been minimized.

Contributor

satyakresna commented Feb 12, 2018

@cristianbote

This comment has been minimized.

Owner

cristianbote commented Mar 1, 2018

Hey @satyakresna, I just did a commit and added the npm run serve command. Would you be willing to update the wording on it? I'm gonna add some comments.

@cristianbote

Looking forward you to your reply.

README.md Outdated
* `npm run copy-assets`
* `npm run html-minify`
* `npm run bundle`
* `npm run build-sw`

This comment has been minimized.

@cristianbote

cristianbote Mar 1, 2018

Owner

Instead of these lines, we could run the npm run build-prod and end up in the same place.

README.md Outdated
* `npm run html-minify`
* `npm run bundle`
* `npm run build-sw`
1. It will generate a `public` folder with assets (html, css, js) inside them. Move to `public` folder and run `python -m SimpleHTTPServer 8080`.

This comment has been minimized.

@cristianbote

cristianbote Mar 1, 2018

Owner

This is no longer needed, you can run npm run serve and would spun up a firebase locally served server.

@satyakresna

This comment has been minimized.

Contributor

satyakresna commented Mar 2, 2018

Hi @cristianbote , just finished based on your request. Done, feel free to check. Thanks a lot.

@cristianbote

This comment has been minimized.

Owner

cristianbote commented Mar 2, 2018

Awesome @satyakresna!

@cristianbote cristianbote merged commit cd08fc5 into cristianbote:master Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment