Theme Check #222

Closed
konradsroka opened this Issue Jul 9, 2013 · 4 comments

Projects

None yet

2 participants

@konradsroka

From Theme Check Plugin:

Possible variable $value found in translation function in functions.php. Translation function calls must NOT contain PHP variables.
Line 1129: return ($key == __($value, 'cc') || $key == $value);
Line 1131: return ($key != __($value, 'cc') || $key != $value);
Line 1133: return ($key >= __($value, 'cc') || $key >= $value);
Line 1135: return ($key <= __($value, 'cc') || $key <= $value);
Line 1137: return ($key < __($value, 'cc') || $key < $value);
Line 1139: return ($key > __($value, 'cc') || $key > $value);
Line 1141: return ($key === __($value, 'cc') || $key === $value);

@slaFFik
slaFFik commented Jul 9, 2013

heh, fixing these for themes repo will duplicate code in theme. But anyway we need to do that, so we will. How urgent?

@konradsroka

@slaFFik wow thanks for the quick answer!

so, in Theme Check Results it's displayed as "RECOMMENDED", not as "REQUIRED" -> so we can decide wether this makes sense in this case or if it can cause any errors or if this could/should be handled different somehow..

@konradsroka

@slaFFik what do YOU think ? ;)

@konradsroka

making quick theme check anyway again, recommended not needed now..

@konradsroka konradsroka closed this Sep 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment