New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Net 4.6.2. Replace KB2919442 with KB3021910. #31

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
2 participants
@Matasx

Matasx commented Oct 18, 2016

  • Added support for .Net 4.6.2
  • Fixed issue #29

Signed-off-by: Martin Matatko matatko.martin@gmail.com

@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Oct 19, 2016

Contributor

Thanks @Matasx I'll check this patch ASAP.

Contributor

Annih commented Oct 19, 2016

Thanks @Matasx I'll check this patch ASAP.

@Matasx

This comment has been minimized.

Show comment
Hide comment
@Matasx

Matasx Nov 21, 2016

Hi, could you please review? Thanks.

Matasx commented Nov 21, 2016

Hi, could you please review? Thanks.

@Annih

Seems OK except my 2 comments.
Please also rebase properly on master (no merge commit please)

Show outdated Hide outdated libraries/package_helper.rb
Show outdated Hide outdated libraries/package_helper.rb
@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Nov 21, 2016

Contributor

Just for my information @Matasx was it hard/complexe to perform this update on the ms_dotnet cookbook?

Contributor

Annih commented Nov 21, 2016

Just for my information @Matasx was it hard/complexe to perform this update on the ms_dotnet cookbook?

@Matasx

This comment has been minimized.

Show comment
Hide comment
@Matasx

Matasx Nov 21, 2016

Thanks for your notes. I will update my branch accordingly tomorrow. FYI it wasn't hard to perform those changes in cookbook itself. Only thing that was challenging for me was to find correct packages, prerequisites and registry checks on MS pages.

Matasx commented Nov 21, 2016

Thanks for your notes. I will update my branch accordingly tomorrow. FYI it wasn't hard to perform those changes in cookbook itself. Only thing that was challenging for me was to find correct packages, prerequisites and registry checks on MS pages.

@Matasx

This comment has been minimized.

Show comment
Hide comment
@Matasx

Matasx Nov 22, 2016

@Annih, hopefully everything should by addressed now.

Matasx commented Nov 22, 2016

@Annih, hopefully everything should by addressed now.

Martin Matatko
Add support for .Net 4.6.2. Replace KB2919442 with KB3021910.
Signed-off-by: Martin Matatko <matatko.martin@gmail.com>
@Annih

Annih approved these changes Nov 22, 2016

Yep, it looks good to me :)

@Annih Annih merged commit 57107e1 into criteo-cookbooks:master Nov 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Nov 22, 2016

Contributor

@Matasx I'll prepare a new 4.0 version of this cookbook including your fix and the pending PR, is it OK for you; or do you need a quicker release?

Contributor

Annih commented Nov 22, 2016

@Matasx I'll prepare a new 4.0 version of this cookbook including your fix and the pending PR, is it OK for you; or do you need a quicker release?

@Matasx

This comment has been minimized.

Show comment
Hide comment
@Matasx

Matasx Nov 22, 2016

@Annih thanks! What is your estimate? If it will be done somewhere in the middle of next week I think I am ok with that.

Matasx commented Nov 22, 2016

@Annih thanks! What is your estimate? If it will be done somewhere in the middle of next week I think I am ok with that.

@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Nov 23, 2016

Contributor

Release will be done today, but it'll be a 3.1 version instead of 4.0 as I previously said :)

Contributor

Annih commented Nov 23, 2016

Release will be done today, but it'll be a 3.1 version instead of 4.0 as I previously said :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment