Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KB3021910 with KB3173424 #38

Merged
merged 1 commit into from Feb 1, 2017
Merged

Conversation

@jakauppila
Copy link
Contributor

jakauppila commented Jan 27, 2017

Fixes #37.

I ran into the same issue, so this fix replaces KB3021910 with KB3173424 within the prerequisites for 4.6, 4.6.1, and 4.6.2 on Windows 8.1 and Windows Server 2012R2.

@jmauro

This comment has been minimized.

Copy link
Contributor

jmauro commented Jan 30, 2017

Hello @jakauppila,

Thanks for th PR, we will look into it as quick as possible, we've been a bit busy recently.
By the way could you remove the bump version commit, Criteo folks usually handle the version bump.

Regards,
JM

PS: You could also rebase to fix the travis test failing issue.

@jakauppila

This comment has been minimized.

Copy link
Contributor Author

jakauppila commented Jan 30, 2017

Hi @jmauro

Sounds good. I removed the version bump.

@jmauro

This comment has been minimized.

Copy link
Contributor

jmauro commented Jan 31, 2017

Hello @jakauppila,

Me again could rebase your commit to the master branch to make sure the test pass? And could you also squash your commit just to reflect the KB3173424 issue?

Regards,
JM

@jakauppila jakauppila force-pushed the jakauppila:fix-37 branch from d845cbd to 8a2410f Feb 1, 2017
@jakauppila jakauppila force-pushed the jakauppila:fix-37 branch from 8a2410f to e20a0ed Feb 1, 2017
@jakauppila

This comment has been minimized.

Copy link
Contributor Author

jakauppila commented Feb 1, 2017

Hi @jmauro

Rebase completed and tests passing!

Thanks

@jmauro

This comment has been minimized.

Copy link
Contributor

jmauro commented Feb 1, 2017

LGTM

@jmauro jmauro merged commit 6327d3a into criteo-cookbooks:master Feb 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.