New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak to make it work properly when there was no previous .Net 4 keys #44

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
2 participants
@smurawski
Contributor

smurawski commented Apr 7, 2017

When testing on 2012/2012R2, I missed the condition where there .net 4 reg keys were totally missing, so the .net 4 installs on 2008R2 would fail.

This fixes that behavior.

Signed-off-by: Steven Murawski steven.murawski@gmail.com

@smurawski

This comment has been minimized.

Show comment
Hide comment
@smurawski

smurawski Apr 7, 2017

Contributor

FYI - All the spec failures are changing rubocop rules on files I've not touched.

Contributor

smurawski commented Apr 7, 2017

FYI - All the spec failures are changing rubocop rules on files I've not touched.

@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Apr 8, 2017

Contributor

I'll fix the version of rubocop used in this cookbook to avoid this situation...

Contributor

Annih commented Apr 8, 2017

I'll fix the version of rubocop used in this cookbook to avoid this situation...

@Annih

This comment has been minimized.

Show comment
Hide comment
@Annih

Annih Apr 11, 2017

Contributor

Hello @smurawski could you rebase on master to use the right version of rubocop? :)

Thanks!

Contributor

Annih commented Apr 11, 2017

Hello @smurawski could you rebase on master to use the right version of rubocop? :)

Thanks!

jugatsu added a commit to jugatsu/ms_dotnet that referenced this pull request Apr 14, 2017

Update framework.rb
Apply criteo-cookbooks#44 to make cookbook work on Windows 7.
set version to 0 when no reg key present
Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
@smurawski

This comment has been minimized.

Show comment
Hide comment
@smurawski

smurawski Apr 17, 2017

Contributor

@Annih rebased! Thanks.

Contributor

smurawski commented Apr 17, 2017

@Annih rebased! Thanks.

@Annih Annih merged commit 6cd2d44 into criteo-cookbooks:master Apr 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Annih added a commit that referenced this pull request Apr 29, 2017

Properly handle the case where .NET is not installed
Chef custom resource has an explicit way to declare non existing value.
Let's use it, instead of using workaround.

This replace #44.

Annih added a commit that referenced this pull request Apr 29, 2017

Properly handle the case where .NET is not installed
Chef custom resource has an explicit way to declare non-existing value.
Let's use it, instead of using workaround.

This replaces #44.

Annih added a commit that referenced this pull request Apr 29, 2017

Properly handle non-installed .NET version
Chef custom resource has an explicit way to declare non-existing value.
Let's use it, instead of using workaround.

I use tap to avoid multiple calls to registry.

This replaces #44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment