[breaking] improve API by removing the Quantizer class and adds in memory support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1504
changed the title
bamine
reviewed
Nov 18, 2021
autofaiss/external/quantize.py
Outdated
|
|
||
|
|
||
| def quantize( | ||
| embeddings_path: str, |
There was a problem hiding this comment.
Can you change name to embeddings_or_path and type to Union[str, np.ndarray] ?
There was a problem hiding this comment.
I changed the type but actually I think it's better if we don't change the argument name, it would be an annoying breaking change with no obvious benefit
bamine
reviewed
Nov 18, 2021
autofaiss/external/quantize.py
Outdated
| print("Recap:") | ||
| pp(metric_infos) | ||
|
|
||
| return index |
There was a problem hiding this comment.
Can you also return the output path ?
rom1504
force-pushed
the
improve_api
branch
2 times, most recently
from
203e0e3
to
14bd0d6
Compare
rom1504
force-pushed
the
improve_api
branch
3 times, most recently
from
d26766c
to
2afcb3c
Compare
…ndex_path explicit
|
reviewed with victor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.