Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Static #92

Merged
merged 1 commit into from May 9, 2019
Merged

Notification Static #92

merged 1 commit into from May 9, 2019

Conversation

mltbnz
Copy link
Member

@mltbnz mltbnz commented May 8, 2019

Updates the apps Notifications to be of type Notification and collect all NNotifications in an extensionn to have the Strings in one place.

Follow up to the #69 PR

  • collect Notifications in an extension
  • update NSNotification to Notification
  • adopt Notifications to new static lets

* collect Notifications in an extension
* update NSNotification to Notification
* adopt Notifications to new static lets
@mltbnz mltbnz requested a review from lennet May 8, 2019 15:46
Copy link
Member

@lennet lennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mltbnz mltbnz merged commit 310b3fd into criticalmaps:master May 9, 2019
@mltbnz mltbnz deleted the NotificationRefactor branch May 12, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants