-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal-kit is failing in meteor. #7
Comments
Hi, Please give me:
Note that the last version of Terminal-kit needs at least Node v4. |
Hi @cronvel I' m guessing it's because of Meteor JS engine (missing prototype when require core module |
Can you confirm that, by running in meteor the code: if (Meteor.isServer) {
Meteor.startup(function () {
console.log( 'Node: ' + process.version ) ;
console.log( 'Versions: ' , process.versions ) ;
});
} I just downloaded Meteor (I never tried it until now), and while I have Node v4.2.2 installed on my system, Meteor seems to use Node v0.10.40. Here is what I get:
By the way, the same in plain Node:
Of course, I'm totally new to meteor, so I may have done something bad somewhere. It looks like meteor download and run its own instance of Mongodb, what about Node? Does it ship its own Node.js? Does it support the ES6 feature included in Node v4? Also, |
Here's my output:
Here's what require("events) look like:
It's seem like meteorJS ship with its own node version , which cause the issue. Do you think this 'll be a simple patch ( check prototype if exist?), or it'll take a lot of rework to support? |
Related issue on meteor : meteor/meteor#5124 |
If the core |
👍 |
What exactly do you want to achieve with Terminal-kit? I managed to get basic features to work as of terminal-kit@v0.22.0, colors and style are working as expected now. However, Meteor interfere with the TTY, and as a result Terminal-kit cannot grab inputs. If you just want colorful log, that's ok. BTW I guess you don't want to create an interactive terminal application. |
I'm writing an solution to allow meteor using external build instead of relying on isobuild. Thanks you for fast response & amazing support 👍 Btw IMO terminal kit come with many bloat feature(like progress bar). Cheers. |
Thanks for your feedback. If you have trouble, let me know! ;) |
I have good news for you! I have added a new built-in terminal instance that might interest you. Instead of using: Using this, you gain access to the real TTY and totally hijack all the meteor stuffs that get in the way when terminal-kit try to read/write from STDIN and STDOUT. This terminal instance also escape from pipe. Using that, you can even use all terminal-kit interactive features, if you need. |
Hey @cronvel , i'm glad you was able to patch it . Great update! |
var x = Npm.require("terminal-kit");
Error:
any idea?
The text was updated successfully, but these errors were encountered: