Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable migrations from 3.x to 4.x #931

Merged
merged 8 commits into from Nov 21, 2019

Conversation

@rchavik
Copy link
Member

rchavik commented Nov 20, 2019

This attempts to enable migrations from 3.x by reusing the old 3.x migration names as stubs.

If we choose to go this route, this PR makes #930 obsolete.

@rchavik rchavik added this to To Do in 4.0.0 via automation Nov 20, 2019
@rchavik rchavik requested a review from dakota Nov 20, 2019
@rchavik

This comment has been minimized.

Copy link
Member Author

rchavik commented Nov 20, 2019

I tested migrating from stock 3.x (installed via composer):

composer require \
    croogo/croogo:4.0-migrations-dev \
    cakephp/cakephp \
    cakephp/acl \
    robmorgan/phinx \
    cakephp/bake:^1.9 \
    cakephp/debug_kit \
    cakephp/migrations \
    friendsofcake/bootstrap-ui:'dev-develop as 2.0.0-beta6' \
    friendsofcake/search:^5.3

Then I had to do the following manually:

  • Edit src/Application.php
  • Comment out loading of Croogo/Core
  • Temporarily add loading of Croogo/FileManager and run the migrations via command line, eg: bin/cake migrations migrate --plugin Croogo/FileManager --no-lock
  • Comment out loading of Croogo/FileManager and uncomment/load Croogo/Core
  • Use the backend to perform migrations of other plugins

I still had issues with Croogo/Taxonomy marked as failed when it was actually successfully migrated.

@rchavik

This comment has been minimized.

Copy link
Member Author

rchavik commented Nov 20, 2019

I still had issues with Croogo/Taxonomy marked as failed when it was actually successfully
migrated.

This is now fixed.

@rchavik

This comment has been minimized.

Copy link
Member Author

rchavik commented Nov 21, 2019

@dakota, @miketallroth good to go?

@dakota
dakota approved these changes Nov 21, 2019
Copy link
Member

dakota left a comment

Looks good. Thanks!

@rchavik rchavik merged commit f76eeb5 into 4.0 Nov 21, 2019
4.0.0 automation moved this from To Do to Done Nov 21, 2019
@rchavik rchavik deleted the 4.0-migrations branch Nov 21, 2019
@rchavik rchavik changed the title Try to enable migrations from 3.x to 4.x Enable migrations from 3.x to 4.x Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0.0
  
Done
2 participants
You can’t perform that action at this time.